docs: update pull request template (#1434)

pull/1435/head
Kagaya 3 years ago committed by GitHub
parent 3f51a15949
commit 842be155a3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 15
      .github/pull_request_template.md

@ -2,7 +2,7 @@
🎉 Thanks for sending a pull request to Kratos! Here are some tips for you: 🎉 Thanks for sending a pull request to Kratos! Here are some tips for you:
1. If this is your first time contributing to Kratos, please read our contribution guide: https://go-kratos.dev/en/docs/community/contribution/ 1. If this is your first time contributing to Kratos, please read our contribution guide: https://go-kratos.dev/en/docs/community/contribution/
2. Ensure you have added or ran the appropriate tests for your PR, such as using `go test ./...` 2. Ensure you have added or ran the appropriate tests and lint for your PR, please use `make lint` and `make test` before filing your PR, use `make clean` to tidy your go mod.
3. If the PR is unfinished, you may need mark it as a WIP(Work In Progress) PR or draft PR 3. If the PR is unfinished, you may need mark it as a WIP(Work In Progress) PR or draft PR
4. Please use a conventional commits format title: `<type>[optional scope]: <description>` 4. Please use a conventional commits format title: `<type>[optional scope]: <description>`
@ -10,13 +10,13 @@
fix: A bug fix fix: A bug fix
feat: A new feature feat: A new feature
deps: Changes external dependencies test: Adding missing tests or correcting existing tests
refactor: A code change that neither fixes a bug nor adds a feature
break: Changes has break change break: Changes has break change
docs: Documentation only changes docs: Documentation only changes
refactor: A code change that neither fixes a bug nor adds a feature deps: Changes external dependencies
style: Changes that do not affect the meaning of the code (white-space, formatting, etc) style: Changes that do not affect the meaning of the code (white-space, formatting, etc)
test: Adding missing tests or correcting existing tests
chore Daily work, examples, etc. chore Daily work, examples, etc.
ci: Changes to our CI configuration files and scripts ci: Changes to our CI configuration files and scripts
--> -->
@ -27,12 +27,17 @@
--> -->
#### Which issue(s) this PR fixes: #### Which issue(s) this PR fixes (resolves / be part of):
<!-- <!--
* Automatically closes linked issue when PR is merged. * Automatically closes linked issue when PR is merged.
* If you PR is not fully resolved issue, please use `part of #<issue number>` instead.
Usage: `fixes/resolves #<issue number>`, or `fixes/resolves (paste link of issue)`. Usage: `fixes/resolves #<issue number>`, or `fixes/resolves (paste link of issue)`.
--> -->
fixes # fixes #
#### Other special notes for reviewer: #### Other special notes for reviewer:
<!--
* Somethings that need extra attention for reviewer
* Some additional notes, TODO list, etc.
-->

Loading…
Cancel
Save