From 842be155a30cb946e085b72e962380d7fd525033 Mon Sep 17 00:00:00 2001 From: Kagaya Date: Tue, 7 Sep 2021 10:02:13 +0800 Subject: [PATCH] docs: update pull request template (#1434) --- .github/pull_request_template.md | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index d52564233..f2bb809ad 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,7 +2,7 @@ 🎉 Thanks for sending a pull request to Kratos! Here are some tips for you: 1. If this is your first time contributing to Kratos, please read our contribution guide: https://go-kratos.dev/en/docs/community/contribution/ -2. Ensure you have added or ran the appropriate tests for your PR, such as using `go test ./...` +2. Ensure you have added or ran the appropriate tests and lint for your PR, please use `make lint` and `make test` before filing your PR, use `make clean` to tidy your go mod. 3. If the PR is unfinished, you may need mark it as a WIP(Work In Progress) PR or draft PR 4. Please use a conventional commits format title: `[optional scope]: ` @@ -10,13 +10,13 @@ fix: A bug fix feat: A new feature - deps: Changes external dependencies + test: Adding missing tests or correcting existing tests + refactor: A code change that neither fixes a bug nor adds a feature break: Changes has break change docs: Documentation only changes - refactor: A code change that neither fixes a bug nor adds a feature + deps: Changes external dependencies style: Changes that do not affect the meaning of the code (white-space, formatting, etc) - test: Adding missing tests or correcting existing tests chore Daily work, examples, etc. ci: Changes to our CI configuration files and scripts --> @@ -27,12 +27,17 @@ --> -#### Which issue(s) this PR fixes: +#### Which issue(s) this PR fixes (resolves / be part of): fixes # #### Other special notes for reviewer: +