fix: nacos registry test data race (#1613)

pull/1615/head
wangcong 3 years ago committed by GitHub
parent 32272fe441
commit c3d0bb66bb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 3
      contrib/config/nacos/config_test.go
  2. 18
      contrib/registry/nacos/registry_test.go

@ -6,11 +6,12 @@ import (
"testing" "testing"
"time" "time"
kconfig "github.com/go-kratos/kratos/v2/config"
"github.com/nacos-group/nacos-sdk-go/clients" "github.com/nacos-group/nacos-sdk-go/clients"
"github.com/nacos-group/nacos-sdk-go/common/constant" "github.com/nacos-group/nacos-sdk-go/common/constant"
"github.com/nacos-group/nacos-sdk-go/vo" "github.com/nacos-group/nacos-sdk-go/vo"
"gopkg.in/yaml.v3" "gopkg.in/yaml.v3"
kconfig "github.com/go-kratos/kratos/v2/config"
) )
func getIntranetIP() string { func getIntranetIP() string {

@ -7,10 +7,11 @@ import (
"testing" "testing"
"time" "time"
"github.com/go-kratos/kratos/v2/registry"
"github.com/nacos-group/nacos-sdk-go/clients" "github.com/nacos-group/nacos-sdk-go/clients"
"github.com/nacos-group/nacos-sdk-go/common/constant" "github.com/nacos-group/nacos-sdk-go/common/constant"
"github.com/nacos-group/nacos-sdk-go/vo" "github.com/nacos-group/nacos-sdk-go/vo"
"github.com/go-kratos/kratos/v2/registry"
) )
func getIntranetIP() string { func getIntranetIP() string {
@ -88,15 +89,18 @@ func TestRegistry(t *testing.T) {
r := New(client) r := New(client)
go func() { go func() {
var w registry.Watcher var (
w, err = r.Watch(ctx, "golang-sms@grpc") w registry.Watcher
if err != nil { watchErr error
log.Fatal(err) )
w, watchErr = r.Watch(ctx, "golang-sms@grpc")
if watchErr != nil {
log.Fatal(watchErr)
} }
for { for {
var res []*registry.ServiceInstance var res []*registry.ServiceInstance
res, err = w.Next() res, watchErr = w.Next()
if err != nil { if watchErr != nil {
return return
} }
log.Printf("watch: %d", len(res)) log.Printf("watch: %d", len(res))

Loading…
Cancel
Save