From d451d57023888ec4c489ad3f880d95890bbd811e Mon Sep 17 00:00:00 2001 From: joeybloggs Date: Sun, 22 Nov 2015 21:33:42 -0500 Subject: [PATCH] Update benchmarks + correct benchmark error * Fix error with BenchmarkFieldFailure, it was recording a successful run. * Update some benchmarks, they were showing allocations for the creation of the data not just processing it. --- README.md | 56 +++++++++++++++++++++++----------------------- benchmarks_test.go | 53 +++++++++++++++++++++++++++++++++++++------ util.go | 6 +++++ validator_test.go | 8 ++----- 4 files changed, 82 insertions(+), 41 deletions(-) diff --git a/README.md b/README.md index 5c8e16e..36f832f 100644 --- a/README.md +++ b/README.md @@ -310,34 +310,34 @@ Benchmarks ```go $ go test -cpu=4 -bench=. -benchmem=true PASS -BenchmarkFieldSuccess-4 5000000 288 ns/op 16 B/op 1 allocs/op -BenchmarkFieldFailure-4 5000000 292 ns/op 16 B/op 1 allocs/op -BenchmarkFieldDiveSuccess-4 500000 3464 ns/op 528 B/op 28 allocs/op -BenchmarkFieldDiveFailure-4 500000 4031 ns/op 928 B/op 32 allocs/op -BenchmarkFieldCustomTypeSuccess-4 3000000 446 ns/op 32 B/op 2 allocs/op -BenchmarkFieldCustomTypeFailure-4 2000000 755 ns/op 400 B/op 4 allocs/op -BenchmarkFieldOrTagSuccess-4 1000000 1356 ns/op 32 B/op 2 allocs/op -BenchmarkFieldOrTagFailure-4 1000000 1177 ns/op 432 B/op 6 allocs/op -BenchmarkStructLevelValidationSuccess-4 2000000 810 ns/op 160 B/op 6 allocs/op -BenchmarkStructLevelValidationFailure-4 1000000 1424 ns/op 592 B/op 11 allocs/op -BenchmarkStructSimpleCustomTypeSuccess-4 1000000 1231 ns/op 80 B/op 5 allocs/op -BenchmarkStructSimpleCustomTypeFailure-4 1000000 1779 ns/op 624 B/op 11 allocs/op -BenchmarkStructPartialSuccess-4 1000000 1396 ns/op 400 B/op 11 allocs/op -BenchmarkStructPartialFailure-4 1000000 1928 ns/op 816 B/op 16 allocs/op -BenchmarkStructExceptSuccess-4 2000000 946 ns/op 368 B/op 9 allocs/op -BenchmarkStructExceptFailure-4 1000000 1396 ns/op 400 B/op 11 allocs/op -BenchmarkStructSimpleCrossFieldSuccess-4 1000000 1241 ns/op 128 B/op 6 allocs/op -BenchmarkStructSimpleCrossFieldFailure-4 1000000 1837 ns/op 560 B/op 11 allocs/op -BenchmarkStructSimpleCrossStructCrossFieldSuccess-4 1000000 1867 ns/op 176 B/op 9 allocs/op -BenchmarkStructSimpleCrossStructCrossFieldFailure-4 500000 2495 ns/op 608 B/op 14 allocs/op -BenchmarkStructSimpleSuccess-4 1000000 1253 ns/op 48 B/op 3 allocs/op -BenchmarkStructSimpleFailure-4 1000000 1852 ns/op 624 B/op 11 allocs/op -BenchmarkStructSimpleSuccessParallel-4 5000000 372 ns/op 48 B/op 3 allocs/op -BenchmarkStructSimpleFailureParallel-4 2000000 784 ns/op 624 B/op 11 allocs/op -BenchmarkStructComplexSuccess-4 200000 8080 ns/op 512 B/op 30 allocs/op -BenchmarkStructComplexFailure-4 100000 12643 ns/op 3416 B/op 72 allocs/op -BenchmarkStructComplexSuccessParallel-4 1000000 2688 ns/op 512 B/op 30 allocs/op -BenchmarkStructComplexFailureParallel-4 300000 4727 ns/op 3416 B/op 72 allocs/op +BenchmarkFieldSuccess-4 5000000 254 ns/op 0 B/op 0 allocs/op +BenchmarkFieldFailure-4 2000000 779 ns/op 400 B/op 4 allocs/op +BenchmarkFieldDiveSuccess-4 500000 3451 ns/op 480 B/op 27 allocs/op +BenchmarkFieldDiveFailure-4 300000 3954 ns/op 880 B/op 31 allocs/op +BenchmarkFieldCustomTypeSuccess-4 3000000 451 ns/op 32 B/op 2 allocs/op +BenchmarkFieldCustomTypeFailure-4 2000000 751 ns/op 400 B/op 4 allocs/op +BenchmarkFieldOrTagSuccess-4 1000000 1312 ns/op 16 B/op 1 allocs/op +BenchmarkFieldOrTagFailure-4 1000000 1206 ns/op 432 B/op 6 allocs/op +BenchmarkStructLevelValidationSuccess-4 2000000 829 ns/op 160 B/op 6 allocs/op +BenchmarkStructLevelValidationFailure-4 1000000 1403 ns/op 592 B/op 11 allocs/op +BenchmarkStructSimpleCustomTypeSuccess-4 1000000 1238 ns/op 80 B/op 5 allocs/op +BenchmarkStructSimpleCustomTypeFailure-4 1000000 1771 ns/op 624 B/op 11 allocs/op +BenchmarkStructPartialSuccess-4 1000000 1399 ns/op 400 B/op 11 allocs/op +BenchmarkStructPartialFailure-4 1000000 1926 ns/op 816 B/op 16 allocs/op +BenchmarkStructExceptSuccess-4 2000000 930 ns/op 368 B/op 9 allocs/op +BenchmarkStructExceptFailure-4 1000000 1381 ns/op 400 B/op 11 allocs/op +BenchmarkStructSimpleCrossFieldSuccess-4 1000000 1253 ns/op 128 B/op 6 allocs/op +BenchmarkStructSimpleCrossFieldFailure-4 1000000 1849 ns/op 560 B/op 11 allocs/op +BenchmarkStructSimpleCrossStructCrossFieldSuccess-4 1000000 1902 ns/op 176 B/op 9 allocs/op +BenchmarkStructSimpleCrossStructCrossFieldFailure-4 500000 2453 ns/op 608 B/op 14 allocs/op +BenchmarkStructSimpleSuccess-4 1000000 1182 ns/op 48 B/op 3 allocs/op +BenchmarkStructSimpleFailure-4 1000000 1842 ns/op 624 B/op 11 allocs/op +BenchmarkStructSimpleSuccessParallel-4 5000000 342 ns/op 48 B/op 3 allocs/op +BenchmarkStructSimpleFailureParallel-4 2000000 665 ns/op 624 B/op 11 allocs/op +BenchmarkStructComplexSuccess-4 200000 7924 ns/op 512 B/op 30 allocs/op +BenchmarkStructComplexFailure-4 100000 12605 ns/op 3415 B/op 72 allocs/op +BenchmarkStructComplexSuccessParallel-4 1000000 2421 ns/op 512 B/op 30 allocs/op +BenchmarkStructComplexFailureParallel-4 300000 4234 ns/op 3416 B/op 72 allocs/op ``` How to Contribute diff --git a/benchmarks_test.go b/benchmarks_test.go index 2c9af0a..84db743 100644 --- a/benchmarks_test.go +++ b/benchmarks_test.go @@ -7,26 +7,56 @@ import ( ) func BenchmarkFieldSuccess(b *testing.B) { + + var s *string + tmp := "1" + s = &tmp + for n := 0; n < b.N; n++ { - validate.Field("1", "len=1") + validate.Field(s, "len=1") } } func BenchmarkFieldFailure(b *testing.B) { + + var s *string + tmp := "12" + s = &tmp + for n := 0; n < b.N; n++ { - validate.Field("2", "len=1") + validate.Field(s, "len=1") } } func BenchmarkFieldDiveSuccess(b *testing.B) { + + m := make([]*string, 3) + t1 := "val1" + t2 := "val2" + t3 := "val3" + + m[0] = &t1 + m[1] = &t2 + m[2] = &t3 + for n := 0; n < b.N; n++ { - validate.Field([]string{"val1", "val2", "val3"}, "required,dive,required") + validate.Field(m, "required,dive,required") } } func BenchmarkFieldDiveFailure(b *testing.B) { + + m := make([]*string, 3) + t1 := "val1" + t2 := "" + t3 := "val3" + + m[0] = &t1 + m[1] = &t2 + m[2] = &t3 + for n := 0; n < b.N; n++ { - validate.Field([]string{"val1", "", "val3"}, "required,dive,required") + validate.Field(m, "required,dive,required") } } @@ -45,7 +75,6 @@ func BenchmarkFieldCustomTypeSuccess(b *testing.B) { func BenchmarkFieldCustomTypeFailure(b *testing.B) { - // validate := New(Config{TagName: "validate"}) validate.RegisterCustomTypeFunc(ValidateValuerType, (*sql.Valuer)(nil), valuer{}) val := valuer{} @@ -56,14 +85,24 @@ func BenchmarkFieldCustomTypeFailure(b *testing.B) { } func BenchmarkFieldOrTagSuccess(b *testing.B) { + + var s *string + tmp := "rgba(0,0,0,1)" + s = &tmp + for n := 0; n < b.N; n++ { - validate.Field("rgba(0,0,0,1)", "rgb|rgba") + validate.Field(s, "rgb|rgba") } } func BenchmarkFieldOrTagFailure(b *testing.B) { + + var s *string + tmp := "#000" + s = &tmp + for n := 0; n < b.N; n++ { - validate.Field("#000", "rgb|rgba") + validate.Field(s, "rgb|rgba") } } diff --git a/util.go b/util.go index f561ea3..10626bc 100644 --- a/util.go +++ b/util.go @@ -59,9 +59,15 @@ func (v *Validate) ExtractType(current reflect.Value) (reflect.Value, reflect.Ki default: if v.hasCustomFuncs { + // fmt.Println("Type", current.Type()) if fn, ok := v.customTypeFuncs[current.Type()]; ok { + + // fmt.Println("OK") + return v.ExtractType(reflect.ValueOf(fn(current))) } + + // fmt.Println("NOT OK") } return current, current.Kind() diff --git a/validator_test.go b/validator_test.go index be4a2a9..1761f33 100644 --- a/validator_test.go +++ b/validator_test.go @@ -181,7 +181,9 @@ type CustomMadeUpStruct struct { } func ValidateValuerType(field reflect.Value) interface{} { + if valuer, ok := field.Interface().(driver.Valuer); ok { + val, err := valuer.Value() if err != nil { // handle the error how you want @@ -1496,12 +1498,6 @@ func TestSQLValue2Validation(t *testing.T) { func TestSQLValueValidation(t *testing.T) { - // customTypes := map[reflect.Type]CustomTypeFunc{} - // customTypes[reflect.TypeOf((*driver.Valuer)(nil))] = ValidateValuerType - // customTypes[reflect.TypeOf(valuer{})] = ValidateValuerType - // customTypes[reflect.TypeOf(MadeUpCustomType{})] = ValidateCustomType - // customTypes[reflect.TypeOf(1)] = OverrideIntTypeForSomeReason - validate := New(&Config{TagName: "validate"}) validate.RegisterCustomTypeFunc(ValidateValuerType, (*driver.Valuer)(nil), valuer{}) validate.RegisterCustomTypeFunc(ValidateCustomType, MadeUpCustomType{})