fix tracing: call tracer.End() in closure. (#928)

4 years ago · aab0d5aa43
parent ba5b8d1ee3
commit aab0d5aa43
1 changed files with 2 additions and 2 deletions
--- a/middleware/tracing/tracing.go
+++ b/middleware/tracing/tracing.go
@ -58,7 +58,7 @@ func Server(opts ...Option) middleware.Middleware {
 				}
 			}
 			ctx, span := tracer.Start(ctx, component, operation, carrier)
-			defer tracer.End(ctx, span, err)
+			defer func() { tracer.End(ctx, span, err) }()

 			reply, err = handler(ctx, req)

@ -95,7 +95,7 @@ func Client(opts ...Option) middleware.Middleware {
 				ctx = metadata.NewOutgoingContext(ctx, md)
 			}
 			ctx, span := tracer.Start(ctx, component, operation, carrier)
-			defer tracer.End(ctx, span, err)
+			defer func() { tracer.End(ctx, span, err) }()

 			reply, err = handler(ctx, req)