fix(config): Support colon as default value in config.yaml (#1332)

pull/1335/head
Giovanny Gutiérrez 3 years ago committed by GitHub
parent 4b6ab21ae5
commit 9a6c03a9e5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      config/config_test.go
  2. 2
      config/options.go

@ -183,6 +183,7 @@ func TestDefaultResolver(t *testing.T) {
"enable": "${ENABLE:false}",
"rate": "${RATE}",
"empty": "${EMPTY:foobar}",
"url": "${URL:http://example.com}",
"array": []interface{}{
"${PORT}",
map[string]interface{}{"foobar": "${NOTEXIST:8081}"},
@ -237,6 +238,11 @@ func TestDefaultResolver(t *testing.T) {
path: "foo.bar.empty",
expect: "",
},
{
name: "test url with default",
path: "foo.bar.url",
expect: "http://example.com",
},
{
name: "test array",
path: "foo.bar.array",

@ -84,7 +84,7 @@ func defaultDecoder(src *KeyValue, target map[string]interface{}) error {
// placeholder format in ${key:default} or $key.
func defaultResolver(input map[string]interface{}) error {
mapper := func(name string) string {
args := strings.Split(strings.TrimSpace(name), ":")
args := strings.SplitN(strings.TrimSpace(name), ":", 2)
if v, has := readValue(input, args[0]); has {
s, _ := v.String()
return s

Loading…
Cancel
Save