fix: examples lint error (#1454)

* fix example lint error

* use latest version lint

* ignore zap Sync error

.github/workflows/lint.yml

@@ -31,7 +31,6 @@ jobs:
       - name: Lint
         uses: golangci/golangci-lint-action@v2
         with:
-          version: v1.42
+          version: latest
           working-directory: ${{ matrix.workdir }}
-          skip-go-installation: true
           skip-pkg-cache: true

Makefile

@@ -9,8 +9,6 @@ BIN		:= 	""
 TOOLS_SHELL="./hack/tools.sh"
 # golangci-lint
 LINTER := bin/golangci-lint
-$(LINTER): 
-	curl -L https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s v1.42.0
 
 # check GOBIN
 ifneq ($(GOBIN),)
@@ -22,6 +20,9 @@ else
 	endif
 endif
 
+$(LINTER): 
+	curl -SL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s latest
+
 all:
 	@cd cmd/kratos && go build && cd - &> /dev/null
 	@cd cmd/protoc-gen-go-errors && go build && cd - &> /dev/null

examples/benchmark/main.go

@@ -36,17 +36,17 @@ func main() {
 	if argsLen > 1 {
 		webFramework = args[1]
 	}
-	if argsLen > 2 {
+	if argsLen > 2 { //nolint:gomnd
 		sleepTime, _ = strconv.Atoi(args[2])
 		if sleepTime == -1 {
 			cpuBound = true
 			sleepTime = 0
 		}
 	}
-	if argsLen > 3 {
+	if argsLen > 3 { //nolint:gomnd
 		port, _ = strconv.Atoi(args[3])
 	}
-	if argsLen > 4 {
+	if argsLen > 4 { //nolint:gomnd
 		samplingPoint, _ = strconv.Atoi(args[4])
 	}
 	sleepTimeDuration = time.Duration(sleepTime) * time.Millisecond
@@ -108,14 +108,14 @@ func kratosHandle(w http2.ResponseWriter, q *http2.Request) {
 			runtime.Gosched()
 		}
 	}
-	w.Write(message)
+	_, _ = w.Write(message)
 }
 
 func GinServer() {
 	gin.SetMode(gin.ReleaseMode)
 	mux := gin.New()
 	mux.GET("/", ginHandler)
-	mux.Run(":" + strconv.Itoa(port))
+	_ = mux.Run(":" + strconv.Itoa(port))
 }
 
 func ginHandler(c *gin.Context) {
@@ -128,13 +128,13 @@ func ginHandler(c *gin.Context) {
 			runtime.Gosched()
 		}
 	}
-	c.Writer.Write(message)
+	_, _ = c.Writer.Write(message)
 }
 
 func EchoServer() {
 	e := echo.New()
 	e.GET("/", echoHandler)
-	e.Start(":" + strconv.Itoa(port))
+	_ = e.Start(":" + strconv.Itoa(port))
 }
 
 func echoHandler(c echo.Context) error {
@@ -147,7 +147,7 @@ func echoHandler(c echo.Context) error {
 			runtime.Gosched()
 		}
 	}
-	c.Response().Write(message)
+	_, _ = c.Response().Write(message)
 	return nil
 }
 
@@ -155,7 +155,7 @@ func MuxServer() {
 	r := mux.NewRouter()
 	r.HandleFunc("/", muxHandle)
 	http2.Handle("/", r)
-	http2.ListenAndServe(":"+strconv.Itoa(port), r)
+	_ = http2.ListenAndServe(":"+strconv.Itoa(port), r)
 }
 
 func muxHandle(w http2.ResponseWriter, q *http2.Request) {
@@ -168,7 +168,7 @@ func muxHandle(w http2.ResponseWriter, q *http2.Request) {
 			runtime.Gosched()
 		}
 	}
-	w.Write(message)
+	_, _ = w.Write(message)
 }
 
 func pow(targetBits int) {

examples/blog/internal/biz/article.go

@@ -2,12 +2,13 @@ package biz
 
 import (
 	"context"
-	"github.com/go-kratos/kratos/v2/log"
 	"time"
+
+	"github.com/go-kratos/kratos/v2/log"
 )
 
 type Article struct {
-	Id        int64
+	ID        int64
 	Title     string
 	Content   string
 	CreatedAt time.Time

examples/blog/internal/data/article.go

@@ -29,7 +29,7 @@ func (ar *articleRepo) ListArticle(ctx context.Context) ([]*biz.Article, error)
 	rv := make([]*biz.Article, 0)
 	for _, p := range ps {
 		rv = append(rv, &biz.Article{
-			Id:        p.ID,
+			ID:        p.ID,
 			Title:     p.Title,
 			Content:   p.Content,
 			CreatedAt: p.CreatedAt,
@@ -45,7 +45,7 @@ func (ar *articleRepo) GetArticle(ctx context.Context, id int64) (*biz.Article,
 		return nil, err
 	}
 	return &biz.Article{
-		Id:        p.ID,
+		ID:        p.ID,
 		Title:     p.Title,
 		Content:   p.Content,
 		CreatedAt: p.CreatedAt,

examples/blog/internal/data/data.go

@@ -16,6 +16,7 @@ import (
 	"go.opentelemetry.io/otel"
 	"go.opentelemetry.io/otel/attribute"
 	"go.opentelemetry.io/otel/trace"
+
 	// init mysql driver
 	_ "github.com/go-sql-driver/mysql"
 )

examples/blog/internal/data/ent/schema/article.go

@@ -1,11 +1,12 @@
 package schema
 
 import (
+	"time"
+
 	"entgo.io/ent"
 	"entgo.io/ent/dialect"
 	"entgo.io/ent/schema/edge"
 	"entgo.io/ent/schema/field"
-	"time"
 )
 
 // Article holds the schema definition for the Article entity.

examples/blog/internal/data/ent/schema/comment.go

@@ -1,11 +1,12 @@
 package schema
 
 import (
+	"time"
+
 	"entgo.io/ent"
 	"entgo.io/ent/dialect"
 	"entgo.io/ent/schema/edge"
 	"entgo.io/ent/schema/field"
-	"time"
 )
 
 // Comment holds the schema definition for the Comment entity.

examples/blog/internal/data/ent/schema/tag.go

@@ -1,11 +1,12 @@
 package schema
 
 import (
+	"time"
+
 	"entgo.io/ent"
 	"entgo.io/ent/dialect"
 	"entgo.io/ent/schema/edge"
 	"entgo.io/ent/schema/field"
-	"time"
 )
 
 // Tag holds the schema definition for the Tag entity.

examples/blog/internal/data/redis.go

@@ -3,6 +3,7 @@ package data
 import (
 	"context"
 	"fmt"
+
 	"github.com/go-redis/redis/v8"
 )
 

examples/blog/internal/server/grpc.go

@@ -14,7 +14,7 @@ import (
 
 // NewGRPCServer new a gRPC server.
 func NewGRPCServer(c *conf.Server, logger log.Logger, blog *service.BlogService) *grpc.Server {
-	var opts = []grpc.ServerOption{
+	opts := []grpc.ServerOption{
 		grpc.Middleware(
 			recovery.Recovery(),
 			tracing.Server(),

examples/blog/internal/server/http.go

@@ -14,7 +14,7 @@ import (
 
 // NewHTTPServer new a HTTP server.
 func NewHTTPServer(c *conf.Server, logger log.Logger, blog *service.BlogService) *http.Server {
-	var opts = []http.ServerOption{
+	opts := []http.ServerOption{
 		http.Middleware(
 			recovery.Recovery(),
 			tracing.Server(),

examples/blog/internal/service/article.go

@@ -50,7 +50,7 @@ func (s *BlogService) GetArticle(ctx context.Context, req *pb.GetArticleRequest)
 	if err != nil {
 		return nil, err
 	}
-	return &pb.GetArticleReply{Article: &pb.Article{Id: p.Id, Title: p.Title, Content: p.Content, Like: p.Like}}, nil
+	return &pb.GetArticleReply{Article: &pb.Article{Id: p.ID, Title: p.Title, Content: p.Content, Like: p.Like}}, nil
 }
 
 func (s *BlogService) ListArticle(ctx context.Context, req *pb.ListArticleRequest) (*pb.ListArticleReply, error) {
@@ -58,7 +58,7 @@ func (s *BlogService) ListArticle(ctx context.Context, req *pb.ListArticleReques
 	reply := &pb.ListArticleReply{}
 	for _, p := range ps {
 		reply.Results = append(reply.Results, &pb.Article{
-			Id:      p.Id,
+			Id:      p.ID,
 			Title:   p.Title,
 			Content: p.Content,
 		})

examples/config/apollo/main.go

@@ -28,6 +28,8 @@ func main() {
 	if err != nil {
 		panic(err)
 	}
+	log.Printf("service: %s", name)
+
 	// Defines the config JSON Field
 	var v struct {
 		Name    string `json:"name"`
@@ -35,7 +37,7 @@ func main() {
 	}
 
 	// Unmarshal the config to struct
-	if err := c.Scan(&v); err != nil {
+	if err = c.Scan(&v); err != nil {
 		panic(err)
 	}
 	log.Printf("config: %+v", v)
@@ -48,12 +50,12 @@ func main() {
 	log.Printf("service: %s", name)
 
 	// watch key
-	if err := c.Watch("name", func(key string, value config.Value) {
-		name, err := value.String()
-		if err != nil {
-			panic(err)
+	if err = c.Watch("name", func(key string, value config.Value) {
+		n, e := value.String()
+		if e != nil {
+			panic(e)
 		}
-		log.Printf("config changed: %s = %s\n", key, name)
+		log.Printf("config changed: %s = %s\n", key, n)
 	}); err != nil {
 		panic(err)
 	}

examples/errors/client/main.go

@@ -4,6 +4,8 @@ import (
 	"context"
 	"log"
 
+	stdhttp "net/http"
+
 	"github.com/go-kratos/kratos/examples/errors/api"
 	pb "github.com/go-kratos/kratos/examples/helloworld/helloworld"
 	"github.com/go-kratos/kratos/v2/errors"
@@ -27,7 +29,7 @@ func callHTTP() {
 	client := pb.NewGreeterHTTPClient(conn)
 	reply, err := client.SayHello(context.Background(), &pb.HelloRequest{Name: "empty"})
 	if err != nil {
-		if errors.Code(err) == 500 {
+		if errors.Code(err) == stdhttp.StatusInternalServerError {
 			log.Println(err)
 		}
 		if api.IsUserNotFound(err) {

examples/errors/server/main.go

@@ -18,7 +18,7 @@ var (
 	// Name is the name of the compiled software.
 	Name = "errors"
 	// Version is the version of the compiled software.
-	Version = "v1.0.0"
+	// Version = "v1.0.0"
 )
 
 // server is used to implement helloworld.GreeterServer.

examples/event/kafka/kafka.go

@@ -2,14 +2,17 @@ package kafka
 
 import (
 	"context"
+	"log"
+
 	"github.com/go-kratos/kratos/examples/event/event"
 	"github.com/segmentio/kafka-go"
-	"log"
 )
 
-var _ event.Sender = (*kafkaSender)(nil)
-var _ event.Receiver = (*kafkaReceiver)(nil)
-var _ event.Event = (*Message)(nil)
+var (
+	_ event.Sender   = (*kafkaSender)(nil)
+	_ event.Receiver = (*kafkaReceiver)(nil)
+	_ event.Event    = (*Message)(nil)
+)
 
 type Message struct {
 	key   string

examples/event/memory/memory.go

@@ -2,14 +2,17 @@ package memory
 
 import (
 	"context"
-	"github.com/go-kratos/kratos/examples/event/event"
 	"log"
 	"sync"
+
+	"github.com/go-kratos/kratos/examples/event/event"
 )
 
-var _ event.Sender = (*memorySender)(nil)
-var _ event.Receiver = (*memoryReceiver)(nil)
-var _ event.Event = (*Message)(nil)
+var (
+	_ event.Sender   = (*memorySender)(nil)
+	_ event.Receiver = (*memoryReceiver)(nil)
+	_ event.Event    = (*Message)(nil)
+)
 
 var (
 	chanMap = struct {
@@ -47,6 +50,7 @@ func (m *memorySender) Send(ctx context.Context, msg event.Event) error {
 	}
 	return nil
 }
+
 func (m *memorySender) Close() error {
 	return nil
 }
@@ -74,9 +78,9 @@ func (m *memoryReceiver) Close() error {
 func NewMemory(topic string) (event.Sender, event.Receiver) {
 	chanMap.RLock()
 	if _, ok := chanMap.cm[topic]; !ok {
-		//chanMap.Lock()
+		// chanMap.Lock()
 		chanMap.cm[topic] = make(chan *Message, ChanSize)
-		//chanMap.Unlock()
+		// chanMap.Unlock()
 	}
 	defer chanMap.RUnlock()
 

examples/event/memory/memory_test.go

@@ -3,9 +3,10 @@ package memory
 import (
 	"context"
 	"fmt"
-	"github.com/go-kratos/kratos/examples/event/event"
 	"testing"
 	"time"
+
+	"github.com/go-kratos/kratos/examples/event/event"
 )
 
 func TestSendAndReceive(t *testing.T) {
@@ -14,7 +15,6 @@ func TestSendAndReceive(t *testing.T) {
 		t.Log(fmt.Sprintf("key:%s, value:%s\n", event.Key(), event.Value()))
 		return nil
 	})
-
 	if err != nil {
 		t.Error(err)
 	}

examples/event/receiver/main.go

@@ -19,10 +19,9 @@ func main() {
 		panic(err)
 	}
 	receive(receiver)
-	select {
-	case <-sigs:
-		_ = receiver.Close()
-	}
+
+	<-sigs
+	_ = receiver.Close()
 }
 
 func receive(receiver event.Receiver) {

examples/event/sender/main.go

@@ -3,6 +3,7 @@ package main
 import (
 	"context"
 	"fmt"
+
 	"github.com/go-kratos/kratos/examples/event/event"
 	"github.com/go-kratos/kratos/examples/event/kafka"
 )

examples/header/server/main.go

@@ -17,7 +17,7 @@ var (
 	// Name is the name of the compiled software.
 	Name = "helloworld"
 	// Version is the version of the compiled software.
-	Version = "v1.0.0"
+	// Version = "v1.0.0"
 )
 
 // server is used to implement helloworld.GreeterServer.

examples/helloworld/client/main.go

@@ -36,7 +36,7 @@ func callHTTP() {
 	log.Printf("[http] SayHello %s\n", reply.Message)
 
 	// returns error
-	reply, err = client.SayHello(context.Background(), &pb.HelloRequest{Name: "error"})
+	_, err = client.SayHello(context.Background(), &pb.HelloRequest{Name: "error"})
 	if err != nil {
 		log.Printf("[http] SayHello error: %v\n", err)
 	}

examples/helloworld/server/main.go

@@ -18,7 +18,7 @@ var (
 	// Name is the name of the compiled software.
 	Name = "helloworld"
 	// Version is the version of the compiled software.
-	Version = "v1.0.0"
+	// Version = "v1.0.0"
 )
 
 // server is used to implement helloworld.GreeterServer.

examples/http/echo/main.go

@@ -1,10 +1,11 @@
 package main
 
 import (
+	"log"
+
 	"github.com/go-kratos/kratos/v2"
 	"github.com/go-kratos/kratos/v2/transport/http"
 	"github.com/labstack/echo/v4"
-	"log"
 )
 
 func main() {

examples/http/errors/main.go

@@ -41,7 +41,7 @@ func errorEncoder(w stdhttp.ResponseWriter, r *stdhttp.Request, err error) {
 	}
 	w.Header().Set("Content-Type", "application/"+codec.Name())
 	w.WriteHeader(se.Code)
-	w.Write(body)
+	_, _ = w.Write(body)
 }
 
 func main() {

examples/http/upload/main.go

@@ -19,7 +19,7 @@ func uploadFile(ctx http.Context) error {
 	}
 	defer file.Close()
 
-	f, err := os.OpenFile(handler.Filename, os.O_WRONLY|os.O_CREATE, 0666)
+	f, err := os.OpenFile(handler.Filename, os.O_WRONLY|os.O_CREATE, 0o666)
 	if err != nil {
 		return err
 	}

examples/i18n/internal/biz/greeter.go

@@ -2,6 +2,7 @@ package biz
 
 import (
 	"context"
+
 	"github.com/go-kratos/kratos/v2/log"
 )
 

examples/i18n/internal/data/data.go

@@ -10,14 +10,13 @@ import (
 var ProviderSet = wire.NewSet(NewData, NewGreeterRepo)
 
 // Data .
-type Data struct {
-	// TODO wrapped database client
+type Data struct { // TODO wrapped database client
 }
 
 // NewData .
 func NewData(c *conf.Data, logger log.Logger) (*Data, func(), error) {
 	cleanup := func() {
-		logger.Log(log.LevelInfo, "closing the data resources")
+		_ = logger.Log(log.LevelInfo, "closing the data resources")
 	}
 	return &Data{}, cleanup, nil
 }

examples/i18n/internal/data/greeter.go

@@ -2,6 +2,7 @@ package data
 
 import (
 	"context"
+
 	"github.com/go-kratos/kratos/examples/i18n/internal/biz"
 	"github.com/go-kratos/kratos/v2/log"
 )

examples/i18n/internal/pkg/middleware/localize/localize.go

@@ -2,6 +2,7 @@ package localize
 
 import (
 	"context"
+
 	"github.com/BurntSushi/toml"
 	"github.com/nicksnyder/go-i18n/v2/i18n"
 	"golang.org/x/text/language"

examples/i18n/internal/server/grpc.go

@@ -15,7 +15,7 @@ import (
 
 // NewGRPCServer new a gRPC server.
 func NewGRPCServer(c *conf.Server, greeter *service.GreeterService, logger log.Logger) *grpc.Server {
-	var opts = []grpc.ServerOption{
+	opts := []grpc.ServerOption{
 		grpc.Middleware(
 			recovery.Recovery(),
 			tracing.Server(),

examples/i18n/internal/server/http.go

@@ -16,7 +16,7 @@ import (
 
 // NewHTTPServer new a HTTP server.
 func NewHTTPServer(c *conf.Server, greeter *service.GreeterService, logger log.Logger) *http.Server {
-	var opts = []http.ServerOption{
+	opts := []http.ServerOption{
 		http.Middleware(
 			recovery.Recovery(),
 			tracing.Server(),

examples/i18n/internal/service/greeter.go

@@ -2,10 +2,11 @@ package service
 
 import (
 	"context"
+
 	"github.com/go-kratos/kratos/examples/i18n/internal/pkg/middleware/localize"
 	"github.com/nicksnyder/go-i18n/v2/i18n"
 
-	"github.com/go-kratos/kratos/examples/i18n/api/helloworld/v1"
+	v1 "github.com/go-kratos/kratos/examples/i18n/api/helloworld/v1"
 	"github.com/go-kratos/kratos/examples/i18n/internal/biz"
 	"github.com/go-kratos/kratos/v2/log"
 )

examples/log/logrus_test.go

@@ -18,9 +18,27 @@ func TestLoggerLog(t *testing.T) {
 		kvs       []interface{}
 		want      string
 	}{
-		"json format":   {level: logrus.InfoLevel, formatter: &logrus.JSONFormatter{}, logLevel: log.LevelInfo, kvs: []interface{}{"case", "json format", "msg", "1"}, want: `{"case":"json format","level":"info","msg":"1"`},
-		"level unmatch": {level: logrus.InfoLevel, formatter: &logrus.JSONFormatter{}, logLevel: log.LevelDebug, kvs: []interface{}{"case", "level unmatch", "msg", "1"}, want: ""},
-		"no tags":       {level: logrus.InfoLevel, formatter: &logrus.JSONFormatter{}, logLevel: log.LevelInfo, kvs: []interface{}{"msg", "1"}, want: `{"level":"info","msg":"1"`},
+		"json format": {
+			level:     logrus.InfoLevel,
+			formatter: &logrus.JSONFormatter{},
+			logLevel:  log.LevelInfo,
+			kvs:       []interface{}{"case", "json format", "msg", "1"},
+			want:      `{"case":"json format","level":"info","msg":"1"`,
+		},
+		"level unmatch": {
+			level:     logrus.InfoLevel,
+			formatter: &logrus.JSONFormatter{},
+			logLevel:  log.LevelDebug,
+			kvs:       []interface{}{"case", "level unmatch", "msg", "1"},
+			want:      "",
+		},
+		"no tags": {
+			level:     logrus.InfoLevel,
+			formatter: &logrus.JSONFormatter{},
+			logLevel:  log.LevelInfo,
+			kvs:       []interface{}{"msg", "1"},
+			want:      `{"level":"info","msg":"1"`,
+		},
 	}
 
 	for name, test := range tests {

examples/log/zap_test.go

@@ -35,5 +35,6 @@ func TestZapLogger(t *testing.T) {
 	zlog.Infow("name", "kratos", "from", "opensource")
 	zlog.Infow("name", "kratos", "from")
 
-	defer logger.Sync()
+	// zap stdout/stderr Sync bugs in OSX, see https://github.com/uber-go/zap/issues/370
+	_ = logger.Sync()
 }

examples/metadata/server/main.go

@@ -18,7 +18,7 @@ var (
 	// Name is the name of the compiled software.
 	Name = "helloworld"
 	// Version is the version of the compiled software.
-	Version = "v1.0.0"
+	// Version = "v1.0.0"
 )
 
 // server is used to implement helloworld.GreeterServer.

examples/metrics/main.go

@@ -21,7 +21,7 @@ var (
 	// Name is the name of the compiled software.
 	Name = "metrics"
 	// Version is the version of the compiled software.
-	Version = "v1.0.0"
+	// Version = "v1.0.0"
 
 	_metricSeconds = prometheus.NewHistogramVec(prometheus.HistogramOpts{
 		Namespace: "server",

examples/registry/consul/client/main.go

@@ -65,5 +65,4 @@ func callHTTP(cli *api.Client) {
 		log.Fatal(err)
 	}
 	log.Printf("[http] SayHello %s\n", reply.Message)
-
 }

examples/registry/registry_test.go

@@ -9,6 +9,7 @@ import (
 
 	"github.com/go-kratos/kratos/examples/helloworld/helloworld"
 	pb "github.com/go-kratos/kratos/examples/helloworld/helloworld"
+	"github.com/stretchr/testify/assert"
 
 	consulregistry "github.com/go-kratos/kratos/contrib/registry/consul/v2"
 	etcdregistry "github.com/go-kratos/kratos/contrib/registry/etcd/v2"
@@ -105,7 +106,7 @@ func TestETCD(t *testing.T) {
 	}
 	callHTTP(t, r)
 	callGRPC(t, r)
-	srv.Stop()
+	assert.NoError(t, srv.Stop())
 }
 
 func TestConsul(t *testing.T) {
@@ -120,5 +121,5 @@ func TestConsul(t *testing.T) {
 	}
 	callHTTP(t, r)
 	callGRPC(t, r)
-	srv.Stop()
+	assert.NoError(t, srv.Stop())
 }

examples/stream/client/main.go

@@ -74,7 +74,6 @@ func uploadLog(client hello.HelloClient) {
 		time.Sleep(time.Millisecond * 50)
 		number++
 	}
-	return
 }
 
 func chat(client hello.HelloClient) {

examples/stream/service/hello.go

@@ -28,6 +28,7 @@ func (s *HelloService) GetNumber(req *pb.GetNumberRequest, conn pb.Hello_GetNumb
 		time.Sleep(time.Second)
 	}
 }
+
 func (s *HelloService) UploadLog(conn pb.Hello_UploadLogServer) error {
 	for {
 		req, err := conn.Recv()
@@ -40,6 +41,7 @@ func (s *HelloService) UploadLog(conn pb.Hello_UploadLogServer) error {
 		fmt.Println(req.Log)
 	}
 }
+
 func (s *HelloService) Chat(conn pb.Hello_ChatServer) error {
 	for {
 		req, err := conn.Recv()

examples/swagger/server/main.go

@@ -19,7 +19,7 @@ var (
 	// Name is the name of the compiled software.
 	Name = "helloworld"
 	// Version is the version of the compiled software.
-	Version = "v1.0.0"
+	// Version = "v1.0.0"
 )
 
 // server is used to implement helloworld.GreeterServer.

examples/tls/server/main.go

@@ -17,7 +17,7 @@ var (
 	// Name is the name of the compiled software.
 	Name = "helloworld"
 	// Version is the version of the compiled software.
-	Version = "v1.0.0"
+	// Version = "v1.0.0"
 )
 
 // server is used to implement helloworld.GreeterServer.

examples/tls/tls_test.go

@@ -16,6 +16,7 @@ import (
 	"github.com/go-kratos/kratos/v2/registry"
 	"github.com/go-kratos/kratos/v2/transport/grpc"
 	"github.com/go-kratos/kratos/v2/transport/http"
+	"github.com/stretchr/testify/assert"
 	etcd "go.etcd.io/etcd/client/v3"
 )
 
@@ -127,6 +128,6 @@ func TestETCD(t *testing.T) {
 	}
 	callHTTP(t, r, tlsConf)
 	callGRPC(t, r, tlsConf)
-	srv.Stop()
-	srvTLS.Stop()
+	assert.NoError(t, srv.Stop())
+	assert.NoError(t, srvTLS.Stop())
 }

examples/traces/app/message/main.go

@@ -25,7 +25,7 @@ var (
 	// Name is the name of the compiled software.
 	Name = "message"
 	// Version is the version of the compiled software.
-	Version = "v1.0.0"
+	// Version = "v1.0.0"
 )
 
 // server is used to implement helloworld.GreeterServer.

examples/traces/app/user/main.go

@@ -29,7 +29,7 @@ var (
 	// Name is the name of the compiled software.
 	Name = "user"
 	// Version is the version of the compiled software.
-	Version = "v1.0.0"
+	// Version = "v1.0.0"
 )
 
 // server is used to implement helloworld.GreeterServer.

examples/validate/main.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"log"
 
-	"github.com/go-kratos/kratos/examples/validate/api"
+	v1 "github.com/go-kratos/kratos/examples/validate/api"
 	"github.com/go-kratos/kratos/v2"
 	"github.com/go-kratos/kratos/v2/middleware/validate"
 	"github.com/go-kratos/kratos/v2/transport/grpc"
@@ -16,7 +16,7 @@ var (
 	// Name is the name of the compiled software.
 	Name = "errors"
 	// Version is the version of the compiled software.
-	Version = "v1.0.0"
+	// Version = "v1.0.0"
 )
 
 type server struct {

hack/.lintcheck_failures

@@ -1,4 +1,3 @@
-./examples
 ./contrib/metrics/datadog
 ./contrib/config/nacos
 ./contrib/config/apollo

hack/tools.sh

@@ -100,7 +100,7 @@ function tidy() {
 }
 
 function help() {
-	echo "use: lint, test, fix, tidy"
+	echo "use: lint, test, test_coverage, fix, tidy"
 }
 
 case $1 in

transport/http/server_test.go

@@ -45,7 +45,7 @@ func TestServer(t *testing.T) {
 	}()
 	time.Sleep(time.Second)
 	testClient(t, srv)
-	_ = srv.Stop(ctx)
+	assert.NoError(t, srv.Stop(ctx))
 }
 
 func testClient(t *testing.T, srv *Server) {