tracing: set tracing status after request. (#911)

4 years ago · 24b1ca6bc3
parent e7926b989d
commit 24b1ca6bc3
1 changed files with 7 additions and 0 deletions
--- a/middleware/tracing/tracing.go
+++ b/middleware/tracing/tracing.go
@ -8,6 +8,7 @@ import (
 	"github.com/go-kratos/kratos/v2/transport/http"
 	"go.opentelemetry.io/otel"
 	"go.opentelemetry.io/otel/attribute"
+	"go.opentelemetry.io/otel/codes"
 	"go.opentelemetry.io/otel/propagation"
 	"go.opentelemetry.io/otel/trace"
 	"google.golang.org/grpc/metadata"
@ -103,6 +104,9 @@ func Server(opts ...Option) middleware.Middleware {
 					attribute.String("event", "error"),
 					attribute.String("message", err.Error()),
 				)
+				span.SetStatus(codes.Error, err.Error())
+			} else {
+				span.SetStatus(codes.Ok, "OK")
 			}
 			return
 		}
@ -158,6 +162,9 @@ func Client(opts ...Option) middleware.Middleware {
 					attribute.String("event", "error"),
 					attribute.String("message", err.Error()),
 				)
+				span.SetStatus(codes.Error, err.Error())
+			} else {
+				span.SetStatus(codes.Ok, "OK")
 			}
 			return
 		}